refactor: simplify subscription and collection-subscriber code

KyleAMathews · claude · KyleAMathews · commit 133a697cb2f4 · 2026-01-29T09:37:03.000-07:00
- Remove redundant has() check before Set.add() (idempotent operation)
- Replace nested ternary with clearer if-statement for minValues

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/packages/db/src/collection/subscription.ts b/packages/db/src/collection/subscription.ts
@@ -683,13 +683,9 @@ export class CollectionSubscription
 
     for (const change of changes) {
       if (change.type === `delete`) {
-        // Remove deleted keys from sentKeys so future re-inserts are allowed
         this.sentKeys.delete(change.key)
       } else {
-        // For inserts and updates, track the key as sent
-        if (!this.sentKeys.has(change.key)) {
-          this.sentKeys.add(change.key)
-        }
+        this.sentKeys.add(change.key)
       }
     }
 
diff --git a/packages/db/src/query/live/collection-subscriber.ts b/packages/db/src/query/live/collection-subscriber.ts
@@ -425,12 +425,12 @@ export class CollectionSubscriber<
       : undefined
 
     // Normalize to array format for minValues
-    const minValues =
-      extractedValues !== undefined
-        ? Array.isArray(extractedValues)
-          ? extractedValues
-          : [extractedValues]
-        : undefined
+    let minValues: Array<unknown> | undefined
+    if (extractedValues !== undefined) {
+      minValues = Array.isArray(extractedValues)
+        ? extractedValues
+        : [extractedValues]
+    }
 
     const loadRequestKey = this.getLoadRequestKey({
       minValues,

Original file line number	Diff line number	Diff line change
`@@ -683,13 +683,9 @@ export class CollectionSubscription`
`683`	`683`
`684`	`684`	`for (const change of changes) {`
`685`	`685`	if (change.type === `delete`) {
`686`		`- // Remove deleted keys from sentKeys so future re-inserts are allowed`
`687`	`686`	`this.sentKeys.delete(change.key)`
`688`	`687`	`} else {`
`689`		`- // For inserts and updates, track the key as sent`
`690`		`- if (!this.sentKeys.has(change.key)) {`
`691`		`- this.sentKeys.add(change.key)`
`692`		`- }`
	`688`	`+ this.sentKeys.add(change.key)`
`693`	`689`	`}`
`694`	`690`	`}`
`695`	`691`