Conversation
Co-Authored-By: Jorge Rui Da Silva Barrios <[email protected]>
CyanVoxel
added
Type: UI/UX
| tr = ThumbRenderer() | ||
| cover_image: Image.Image = tr._epub_cover(file_path) | ||
|
|
||
| assert cover_image is not None |
Contributor
There was a problem hiding this comment.
I'd suggest to make a test which will actually check the final result as well similarly as done here for pdf:
Co-Authored-By: yed <[email protected]>
Member
Author
|
Implemented the improved test 👍 I'll do the same for the other PRs as well. Also we're having unrelated issues with the pytest workflow, so these tests are going to fail here regardless until that's resolved |
Contributor
|
nit: the |
CyanVoxel
removed
Priority: Low
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a port of #387 which previously targeted
thumbnails/Alpha-v9.4tomain(aka v9.5x).This adds thumbnail/preview support for ePub files.