Skip to content

Fix tag search to not require wildcards#481

Merged
CyanVoxel merged 3 commits intoTagStudioDev:mainfrom
Tyrannicodin:fix-tag-search
Sep 12, 2024
Merged

Fix tag search to not require wildcards#481
CyanVoxel merged 3 commits intoTagStudioDev:mainfrom
Tyrannicodin:fix-tag-search

Conversation

@Tyrannicodin
Copy link
Contributor

@Tyrannicodin Tyrannicodin commented Sep 9, 2024

Previously, searching for tags required % wildcards to be added either side in order to search for a tag without an exact match, however this removes that requirement.

@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion TagStudio: Tags Relating to the TagStudio tag system TagStudio: Search The TagStudio search engine Status: Changes Requested Changes are requested to this labels Sep 9, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Sep 10, 2024
@Tyrannicodin Tyrannicodin mentioned this pull request Sep 11, 2024
Closed
yedpodtrzitko
yedpodtrzitko suggested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@yedpodtrzitko yedpodtrzitko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test for this scenario, so there wont be any regression in future, thanks.

@Tyrannicodin
Copy link
Contributor Author

Tyrannicodin commented Sep 11, 2024 •
edited
Loading

please add a test for this scenario, so there wont be any regression in future, thanks.

Sorry, I'm not sure how test for this, since it was purely an issue with the SQL interaction and I can't see any other examples of a SQL test.

@yedpodtrzitko
Copy link
Contributor

yedpodtrzitko commented Sep 11, 2024

here's a test for tag name lookup, so you can add it there:

TagStudio/tagstudio/tests/test_library.py

Lines 77 to 90 in af642a7

def test_tag_search(library):
tag = library.tags[0]
assert library.search_tags(
FilterState(tag=tag.name.lower()),
)
assert library.search_tags(
FilterState(tag=tag.name.upper()),
)
assert not library.search_tags(
FilterState(tag=tag.name * 2),
)

Looking on the test again, it would be better to use @pytest.mark.parametrize() similarly as here, but that's optional:

TagStudio/tagstudio/tests/test_library.py

Lines 342 to 350 in af642a7

@pytest.mark.parametrize(
["query_name", "has_result"],
[
("foo", 1), # filename substring
("bar", 1), # filename substring
("one", 0), # path, should not match
],
)
def test_search_file_name(library, query_name, has_result):

@Tyrannicodin
Copy link
Contributor Author

Tyrannicodin commented Sep 11, 2024

Added a test 👍

@CyanVoxel CyanVoxel added Priority: Medium An issue that shouldn't be be saved for last and removed Status: Changes Requested Changes are requested to this labels Sep 11, 2024
@CyanVoxel CyanVoxel added the Status: Mergeable The code is ready to be merged label Sep 12, 2024
@CyanVoxel
Copy link
Member

CyanVoxel commented Sep 12, 2024

Mergeable once the Ruff error is addressed

@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Sep 12, 2024
@CyanVoxel CyanVoxel merged commit 2f2f763 into TagStudioDev:main Sep 12, 2024
@Computerdores Computerdores moved this to ✅ Done in TagStudio Development Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yedpodtrzitko yedpodtrzitko yedpodtrzitko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Priority: Medium An issue that shouldn't be be saved for last TagStudio: Search The TagStudio search engine TagStudio: Tags Relating to the TagStudio tag system Type: QoL A quality of life (QoL) enhancement or suggestion

Projects

TagStudio Development
Status: ✅ Done

Milestone

SQL Parity

Development

Successfully merging this pull request may close these issues.

3 participants

@Tyrannicodin @yedpodtrzitko @CyanVoxel