fix: renderer type fixes#1114
Conversation
CyanVoxel
added
the
Type: Refactor
|
fixed merge conflict |
|
for me all pyright issues are fixed now. Only thing I am not a particular fan of is the number of ignore comments on |
My longer term solution is to overhaul that thing to have different getters deepening on the type you expect. I have no idea what's going on with the type stuff over there, only that it's guaranteed that no other part of the code can ever be happy with the type it spits out... |
| elif ext in [".mp4", ".m4a", ".aac"]: | ||
| mp4_tags: mp4.MP4 = mp4.MP4(filepath) | ||
| mp4_covers: list = mp4_tags.get("covr") | ||
| mp4_covers: list = mp4_tags.get("covr") # pyright: ignore[reportAssignmentType] |
There was a problem hiding this comment.
Just out of curiosity, are you also seeing the reportUnknownVariableType warning for these lines?
There was a problem hiding this comment.
I didn't otherwise I would have set it to ignored. Only have nvim available today though, so can't check
github-project-automation
bot
moved this from 🍃 Pending Merge
to ✅ Done
in TagStudio Development
2 participants
Summary
Mostly type fixes in renderer also some other small ones. Split from #1113 to keep PR size on the smaller end.
Tasks Completed