Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TabularisDB/tabularis-sqlserver-plugin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.0-beta.1
Choose a base ref
...
head repository: TabularisDB/tabularis-sqlserver-plugin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.0-beta.2
Choose a head ref
  • 9 commits
  • 24 files changed
  • 3 contributors

Commits on Sep 16, 2026

  1. Configuration menu
    Copy the full SHA
    f729dc8 View commit details
    Browse the repository at this point in the history
  2. feat: support Windows/Kerberos integrated authentication

    Enable the mssql-tds-preview crate's default sspi/gssapi features and
    map AuthMethod::Integrated when integrated_auth is set. Accept
    Integrated Security / Trusted_Connection in connection strings instead
    of hard-rejecting them, and reject the combination with a
    username/password instead of silently picking one.
    
    Also accept the Command Timeout keyword as a client-side no-op,
    matching the existing Connect Timeout handling.
    
    Co-Authored-By: Claude Sonnet 5 <[email protected]>
    Egert Aia and claude committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    660eee0 View commit details
    Browse the repository at this point in the history
  3. docs: document integrated_auth in README

    Co-Authored-By: Claude Sonnet 5 <[email protected]>
    Egert Aia and claude committed Sep 16, 2026
    Configuration menu
    Copy the full SHA
    0fca522 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2026

  1. feat: move Windows auth checkbox into a UI extension, per host #780

    TabularisDB/tabularis#780 supersedes the host-side capability/field
    approach from #775 with a generic connection-modal.extra_fields hook
    (credentialFieldsHidden/setCredentialFieldsHidden) plus the existing
    opaque extra map, so no core schema change is needed. Rebuild this
    plugin's side on top of that:
    
    - Add ui/, a Vite+React IIFE bundle (per PLUGIN_GUIDE.md) contributing
      the "Use Windows Authentication" checkbox to connection-modal.extra_fields,
      gated to driver "sqlserver". It writes extra.integrated_auth and calls
      setCredentialFieldsHidden; degrades to a visible-but-unhidden checkbox
      on hosts without that hook.
    - ConnectionParams gains extra: HashMap<String, String>; resolve_connection_params
      now also resolves integrated_auth from extra["integrated_auth"] == "true",
      in addition to the existing Integrated Security=True connection-string path.
      Restructured the early-return so this works without a connection string.
    - Fix build_connection_key: it never folded auth mode into the pool cache
      key, so editing a saved connection between SQL and Windows auth could
      reuse a stale pool built under the previous credentials.
    - .tabularium: drop the now-unused supports_integrated_auth capability,
      add the ui_extensions entry for the new checkbox.
    - README: document the checkbox as a UI extension instead of a discrete
      connection field.
    
    Co-Authored-By: Claude Sonnet 5 <[email protected]>
    Egert Aia and claude committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    0de3996 View commit details
    Browse the repository at this point in the history
  2. fix: address /pr-review-toolkit:review-pr findings on integrated auth

    Four parallel reviews (code quality, test coverage, silent failures,
    comment accuracy) on the current diff surfaced two real correctness
    bugs and a CI gap, all fixed here:
    
    - resolve_connection_params: a connection-string Integrated Security=False
      silently overrode an extra["integrated_auth"]=true with no error, unlike
      every other dual-sourced field in this function (which reconcile/reject
      on conflict). Now raises a contradiction error instead.
    - extra["integrated_auth"] used a brittle exact match against the literal
      string "true", unlike this file's own parse_bool convention used for the
      same flag in connection strings (case-insensitive, hard-errors on
      garbage instead of silently defaulting to SQL auth). Now reuses parse_bool.
    - ui/ was never typechecked or built in CI — only in release.yml, so a
      TypeScript error would first surface at release time. Added a ci.yml job
      mirroring explain-package's pattern, and switched release.yml to `npm ci`
      since ui/package-lock.json is committed.
    - Added the missing test coverage the reviews identified: extra-map +
      connection-string agreeing/disagreeing on integrated_auth, and a
      driver/pool.rs test for the AuthMethod::Integrated branch.
    - Fixed two doc comments left inaccurate by earlier edits in this branch
      (pool_manager.rs's illustrative key layout and README wording).
    
    Co-Authored-By: Claude Sonnet 5 <[email protected]>
    Egert Aia and claude committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    925b816 View commit details
    Browse the repository at this point in the history
  3. style: trim doc comments to 1-2 lines

    Cut the ratio of prose to code introduced across this branch's edits.
    No behavior change.
    
    Co-Authored-By: Claude Sonnet 5 <[email protected]>
    Egert Aia and claude committed Sep 17, 2026
    Configuration menu
    Copy the full SHA
    9e2f030 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2026

  1. fix: sync credential hiding when a saved connection loads

    IntegratedAuthToggle only called setCredentialFieldsHidden from onChange, so
    reopening a saved connection with extra.integrated_auth=true left the
    username/password inputs visible. Move the call into an effect keyed on the
    flag so mount and load sync too.
    
    Also require Tabularis 0.24.1-2 (first nightly containing
    TabularisDB/tabularis#780) in .tabularium and the README, and add a vitest
    regression test wired into CI.
    
    Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
    Egert Aia and claude committed Sep 21, 2026
    Configuration menu
    Copy the full SHA
    1461733 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #25 from egertaia/feat/windows-integrated-auth

    feat: support Windows/Kerberos integrated authentication
    debba authored Sep 21, 2026
    Configuration menu
    Copy the full SHA
    bee2ac5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    809bf0c View commit details
    Browse the repository at this point in the history
Loading