Repository navigation
Fix cell updates failing with "missing 'pk_col' parameter" - #1
Merged
Merged
Conversation
The host sends the primary key as a pk_map object (column -> value, supporting composite keys), while the plugin only read the pk_col/pk_val pair documented in the plugin guide, so every cell update failed with "missing 'pk_col' parameter". Accept pk_map first and fall back to pk_col/pk_val; NULL key values compare with IS NULL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Updating (or deleting) a row from the data grid always failed with:
The plugin read the primary key from the
pk_col/pk_valparameters documented in the plugin guide, but the host actually sends apk_mapobject (column → value), which also supports composite primary keys (src-tauri/src/plugins/driver.rsin the host).Same fix as TabularisDB/tabularis-oracle-plugin#2.
Fix
update_recordanddelete_recordnow readpk_mapfirst and fall back to the documentedpk_col/pk_valpair for compatibility.WHEREclause is built from all key columns with bound parameters;NULLkey values compare withIS NULL(a bound= NULLwould never match).Testing
pk_map(composite), the legacypk_col/pk_valfallback,NULLkey handling, and missing-parameter errors.