Repository navigation
fix: prevent concurrent task metadata corruption - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent
fm_setandfm_delcalls sharedTASK.md.tmpand performed unlocked read-modify-write operations, causing lost updates and missing-temp rename errors. Serialize each complete mutation with a Bash 3.2-compatible per-file lock, write through a unique adjacent temporary file, and preserve the original on failures.Cleanup traps release locks and temporary files on failure and termination while preserving caller traps and file permissions. Lock acquisition is bounded; SIGKILL or a machine crash can leave a stale lock requiring manual cleanup after confirming no writer owns it.
Require both success and a verbose creation receipt from
mkdirto handle Ubuntu 26.04's uutils race bug, where losing racers can incorrectly exit successfully. The concurrent regression reproduced this on Ubuntu 26.04, and a deterministic false-success regression protects the workaround.Validation:
make check: lint and all 218 tests passed locally on macOS after pulling the latest main.git diff --checkpassed.