Update Offset Data#1279
Merged
Merged
Conversation
Tweak the OffsetDataColsCounter function to properly break up WRLD \ OFST \ Rows by the actual Y cell range of the worldspace Also set Collapsed flag on the Columns within each row for performance reasons.
Add dfCollapsed flags and cpIgnore. Also put the various parts of the definition to multiple rows for easier reading. And changed Rows to Row and Offset to Column, to be more consistent with other Row/Column type data.
Changes the wbDumpOffset result to be in decimal instead of hex for convenience. Can switch it back if you want to keep it in hex.
Add NoCopyAsOverride flag to OFST on WRLD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweak the OffsetDataColsCounter function to properly break up WRLD \ OFST \ Rows by the actual Y cell range of the worldspace
Also set Collapsed flag on the Columns within each row for performance reasons.