Skip to content

Conflict colors are not refreshed when filter is re-applied #1240

Description

@thelapdragon

What is the version of xEdit you are using?
SF1Edit 4.1.4w EXTREMELY EXPERIMENTAL (RC6 for 4.1.5) x64 (CEBBD766)

Describe the bug
If you apply a blank filter to the plugins so that xEdit will conflict colorize them, it does so, but if you remove and re-apply the filter, it does not re-colorize new or resolved conflicts - it just reuses the previous colors.

To reproduce

  1. Load all plugins
  2. Apply a filter with no filters enabled, so that all xEdit does is apply conflict coloring.
  3. Resolve or create a conflict that changes the color of a form - it won't change the tree color (which is known), but it does update the record colors in the form itself.
  4. Clear the existing filter
  5. Re-apply the filter you applied in step 2
  6. Go to the record that you modified in step 3
  7. Observe that the tree color coding for the plugin or tree records have not changed to reflect the new conflict status, even though the form values are still displaying the correct color.

Expected behavior
The tree coloring should update after a filter refresh to show accurate conflict coloring - optimally it would update inline as conflicts are adjusted (as xEdit used to do), but I understand that is a project for later.

Screenshots
N/A

Additional context
N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions