-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: winget #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: winget #1844
Conversation
4971c6f to
7770668
Compare
3d3f756 to
136c388
Compare
This reverts commit 4d5d6e0.
136c388 to
4dd67bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 27
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| $installerContent = ($installerTemplate -split "`n" | Where-Object { | ||
| $_.Trim() -notmatch '^#' -and $_.Trim() -ne '' | ||
| }) -join "`n" | ||
| $installerContent = $installerContent -replace '__VERSION__', $Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Version mismatch between installer and other manifests
The installer manifest's __VERSION__ placeholder is replaced with $Version (which may include the v prefix, e.g., "v0.11.35"), while the version manifest and locale manifests use $VersionClean (without the prefix, e.g., "0.11.35"). This causes a PackageVersion mismatch between manifest files, which will fail winget-pkgs validation since all manifests must have matching PackageVersion values. The InstallerUrl correctly needs the v prefix for GitHub download URLs, but a separate replacement is needed there while PackageVersion should use $VersionClean.
| cc: @${actor} | ||
| `; | ||
|
|
||
| console.log(issue_body); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Failure notification step only logs without creating issue
The "Notify on failure" step constructs a detailed GitHub issue body with markdown formatting, troubleshooting steps, and a cc: @${actor} mention, but only calls console.log(issue_body) instead of actually creating an issue via github.rest.issues.create(). The CC mention syntax only works in GitHub issues, not console logs, strongly indicating this was intended to create an issue for visibility when the workflow fails, but the API call was never implemented.
* fix: remove the version lock on ten_ai_base (#1818) * fix: remove the version lock on ten_ai_base * fix: revert --------- Co-authored-by: Ethan Zhang <[email protected]> * feat: add a python system package `pytest_ten` supporting AAA-style tests (#1838) * feat: add a python test wrapper supporting AAA-style tests * fix: use relative import * feat: move test_wrapper from ten_runtime into core_system package * test: add example tests using pytest_ten * chore: refine code * feat: update workflow to upload pytest_ten system package * fix: refine code * fix: test case on windows --------- Co-authored-by: xxxxl_sun <[email protected]> Co-authored-by: sunxilin <[email protected]> * fix: elevenlabs asr language (#1842) Co-authored-by: liaochenliang <[email protected]> * feat: support tman install app (#1845) Co-authored-by: Hu Yueh-Wei <[email protected]> * refactor(property): rename max_tokens to max_completion_tokens for clarity (#1848) Update property.json files to use more descriptive parameter name max_completion_tokens instead of max_tokens. Also includes minor text and voice setting adjustments. * feat: add gradium tts (#1843) * feat: add gradium tts * style(gradium_tts_python): improve code formatting and line wrapping * refactor: simplify error logging and config handling * fix: update licence when uploading to ppa (#1851) * feat: winget (#1844) * feat: winget (dry run when push) * fix: remove potential code injection * fix: variable format * fix: build command args * chore: test production run, trigger PR to winget-pkgs * fix: higher rate limit * Revert "chore: test production run, trigger PR to winget-pkgs" This reverts commit 4d5d6e0. * chore: modify PackageIdentifier * chore: refine codes * fix: trigger * chore: refine codes * chore: refine codes * chore: refine template * fix: license type * fix: refine codes --------- Co-authored-by: Nie Zhihe <[email protected]> Co-authored-by: Hu Yueh-Wei <[email protected]> * fix: update minimax api endpoint from .com to .io (#1852) * refactor: simplify build command by removing redundant clean task (#1849) Co-authored-by: Ethan Zhang <[email protected]> * fix(voice-assistant-live2d): update voice settings and api endpoint * fix: update minimax websocket url from minimaxi.io to minimax.io (#1854) --------- Co-authored-by: xxxxl_sun <[email protected]> Co-authored-by: Ethan Zhang <[email protected]> Co-authored-by: Jun <[email protected]> Co-authored-by: sunxilin <[email protected]> Co-authored-by: liaochenliang <[email protected]> Co-authored-by: liaochenliang <[email protected]> Co-authored-by: Hu Yueh-Wei <[email protected]> Co-authored-by: Nie Zhihe <[email protected]> Co-authored-by: Nie Zhihe <[email protected]>
Note
Automates publishing tman to Winget by adding a GitHub Actions workflow, manifest templates, and a submission PowerShell script.
.github/workflows/update_winget.ymlto auto-update Winget on successful Windows release or manual dispatch.tman-win-release-x64.zip, fetches version, installsgh, runs submission script, posts run summary, and reports failures.tools/winget/submit-to-winget.ps1to download asset, compute/verify SHA256, generate manifests, fork/clonemicrosoft/winget-pkgs, create branch, and open PR.manifest.version.yaml.template,manifest.installer.yaml.template(portabletman.exein zip), and locale manifestsen-US,zh-CN,zh-TW,ja-JP,ko-KRforten-framework.tman.Written by Cursor Bugbot for commit 0c68549. This will update automatically on new commits. Configure here.