Skip to content

Conversation

@cyfyifanchen
Copy link
Contributor

No description provided.

@plutoless plutoless merged commit 00afc10 into TEN-framework:main Jun 20, 2024
BenWeekes pushed a commit that referenced this pull request Nov 3, 2025
Critical Issues Fixed (#1-4 from code review):
1. Race Condition in Queue Flush (agent.py:198) - Remove empty() check before get_nowait() to avoid TOCTOU
2. Missing Error Handling for Tool Calls (llm_exec.py:216) - Add validation and exception handling
3. Event Loop Anti-Pattern (llm_exec.py:52) - Remove get_event_loop() from __init__, add start() method
4. Unbounded Context Growth (llm_exec.py:140) - Implement sliding window (MAX_CONTEXT_LENGTH=20)

These fixes prevent runtime crashes, resource leaks, and memory exhaustion.
BenWeekes pushed a commit that referenced this pull request Nov 3, 2025
Critical Issues Fixed (#1-4 from code review):
1. Race Condition in Queue Flush (agent.py:198) - Remove empty() check before get_nowait() to avoid TOCTOU
2. Missing Error Handling for Tool Calls (llm_exec.py:216) - Add validation and exception handling
3. Event Loop Anti-Pattern (llm_exec.py:52) - Remove get_event_loop() from __init__, add start() method
4. Unbounded Context Growth (llm_exec.py:140) - Implement sliding window (MAX_CONTEXT_LENGTH=20)

These fixes prevent runtime crashes, resource leaks, and memory exhaustion.
BenWeekes pushed a commit that referenced this pull request Nov 3, 2025
Critical Issues Fixed (#1-4 from code review):
1. Race Condition in Queue Flush (agent.py:198) - Remove empty() check before get_nowait() to avoid TOCTOU
2. Missing Error Handling for Tool Calls (llm_exec.py:216) - Add validation and exception handling
3. Event Loop Anti-Pattern (llm_exec.py:52) - Remove get_event_loop() from __init__, add start() method
4. Unbounded Context Growth (llm_exec.py:140) - Implement sliding window (MAX_CONTEXT_LENGTH=20)

These fixes prevent runtime crashes, resource leaks, and memory exhaustion.
BenWeekes pushed a commit that referenced this pull request Nov 3, 2025
Critical Issues Fixed (#1-4 from code review):
1. Race Condition in Queue Flush (agent.py:198) - Remove empty() check before get_nowait() to avoid 
TOCTOU
2. Missing Error Handling for Tool Calls (llm_exec.py:216) - Add validation and exception handling
3. Event Loop Anti-Pattern (llm_exec.py:52) - Remove get_event_loop() from __init__, add start() 
method
4. Unbounded Context Growth (llm_exec.py:140) - Implement sliding window (MAX_CONTEXT_LENGTH=20)

These fixes prevent runtime crashes, resource leaks, and memory exhaustion.
@claude claude bot mentioned this pull request Nov 11, 2025
BenWeekes pushed a commit that referenced this pull request Nov 12, 2025
@claude claude bot mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants