You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b79d396
Browse filesBrowse the repository at this point in the historyBrowse files
Use concat_elements_dyn from arrow-rs (apache#23211)
## Which issue does this PR close?
- Closesapache#23210
## Rationale for this change
apache/arrow-rs#9876 added `ByteView` and
`FixedSizeBinary` support to `concat_elements_dyn` in `arrow-rs`. As a
consequence the extended implementation in DataFusion can now be
replaced by a call to the `arrow-rs` implementation.
## What changes are included in this PR?
- Remove the `kernels::concat_elements_utf8view` and
`kernels::concat_elements_binary_view_array`
- Replace implementation of `binary::concat_elements` with a call to
`arrow::compute::kernels::concat_elements::concat_elements_dyn`
## Are these changes tested?
- Usage is covered by existing tests
- The kernels themselves are tested in `arrow-rs`
## Are there any user-facing changes?
No, two `pub` functions have been removed from `kernel`, but `kernel`
itself is not `pub`.
0 commit comments