Repository navigation
Commit 1ed57cb
authored
[execution] Remove deprecated disk manager configuration API (apache#23139)
### Which issue does this PR close?
- Part of apache#23080
### Rationale for this change
`DiskManagerConfig` and `DiskManager::try_new` were deprecated in
version 48.0.0 in favor of the new `DiskManagerBuilder`. This PR remove
this deprecated methods and update Runtime env initialization logic
### What changes are included in this PR?
- Removed `RuntimeEnvBuilder::with_disk_manager` depercated method.
- Removed deprecated `DiskManagerConfig` enum and its associated
constructor methods.
- Removed deprecated `DiskManager::try_new` method.
- Refactored `RuntimeEnvBuilder` to store `Option<Arc<DiskManager>>`
instead of the old configuration enum.
- Update `RuntimeEnvBuilder::build` logic by using matching to handle
the existing manager, builder, or default initialization.
### Are these changes tested?
verifed by running local tests
### Are there any user-facing changes?
Yes. This removes the deprecated public Rust APIs
`RuntimeEnvBuilder::with_disk_manager`, `DiskManagerConfig` and
`DiskManager::try_new`. Downstream users who need to configure the disk
manager should migrate to using `DiskManager::builder`.
This is an API change and should be labeled as `api change`.1 parent 5fcc550 commit 1ed57cb
2 files changed
Lines changed: 10 additions & 97 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | 120 | | |
161 | 121 | | |
162 | 122 | | |
| |||
192 | 152 | | |
193 | 153 | | |
194 | 154 | | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | 155 | | |
231 | 156 | | |
232 | 157 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
333 | 332 | | |
334 | 333 | | |
335 | 334 | | |
336 | | - | |
337 | 335 | | |
338 | | - | |
| 336 | + | |
339 | 337 | | |
340 | 338 | | |
341 | 339 | | |
| |||
371 | 369 | | |
372 | 370 | | |
373 | 371 | | |
374 | | - | |
375 | | - | |
376 | | - | |
377 | | - | |
378 | | - | |
379 | | - | |
380 | | - | |
381 | | - | |
382 | 372 | | |
383 | 373 | | |
384 | 374 | | |
| |||
472 | 462 | | |
473 | 463 | | |
474 | 464 | | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
475 | 471 | | |
476 | 472 | | |
477 | | - | |
478 | | - | |
479 | | - | |
480 | | - | |
481 | | - | |
482 | | - | |
| 473 | + | |
483 | 474 | | |
484 | 475 | | |
485 | 476 | | |
| |||
511 | 502 | | |
512 | 503 | | |
513 | 504 | | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
| 505 | + | |
518 | 506 | | |
519 | 507 | | |
520 | 508 | | |
| |||
0 commit comments