Skip to content

Commit b86cd48

Browse files
committed
Skip a test in critest which is flakey under GitHub Actions
The test is still run by the periodic build (and any test runs by individuals locally) so the fall in coverage is unimportant. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
1 parent 0c70165 commit b86cd48

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,8 @@ jobs:
340340
Start-Process -FilePath containerd.exe -NoNewWindow -RedirectStandardError true -PassThru
341341
get-process | sls containerd
342342
start-sleep 5
343-
critest.exe --runtime-endpoint=npipe://.//pipe//containerd-containerd --test-images-file='${{env.CRI_TEST_IMAGES}}' --report-dir='${{github.workspace}}/critestreport'
343+
# Skipping a test which is flakey under GitHub Actions, see https://github.com/containerd/containerd/issues/6652
344+
critest.exe --runtime-endpoint=npipe://.//pipe//containerd-containerd --test-images-file='${{env.CRI_TEST_IMAGES}}' --report-dir='${{github.workspace}}/critestreport' -'ginkgo.skip'='runtime should support exec with tty=true and stdin=true'
344345
- uses: actions/upload-artifact@v2
345346
if: always()
346347
with:

0 commit comments

Comments
 (0)