Conversation
- Moved implementations of all functions not considered model-level per the specification from org.omg.sysml.expressions.functions to org.omg.sysml.execution.expressions.functions. - Only library functions registered with the INSTANCE of org.omg.sysml.expressions.ModelLevelEvaluableLibraryFunctionFactory are now considered model-level evaluable.
- Moved SequenceFunction tests out of ModelLevelEvaluationTest, because SequenceFunctions are not currently model-level evaluable per the spec. - Added tests for evaluation of expressions using ControlFunctions collect and select. These functions are model-level evaluable, but cannot be usefully used because of problem with model-level evaluability of body expressions with result expressions that reference parameters. - Added a few tests for collect and select into ModelLevelEvaluationTest just to confirm that they the functions themselves are considered model-level evaluable.
Member
|
I found |
Member
|
I confirmed But as you said, it's pity that I could not use: |
Member
Author
Thanks for catching this. I have fixed the description. |
himi
approved these changes
Nov 29, 2025
Member
|
Thank you for fixing the description. (But |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the conformance of the implementation of the evaluation of model-level evaluable expressions with the SysML 2.0 specification.
Changed library function implementations
The following functions had been implemented as model-level evaluable, but they are not specified as model-level evaluable for SysML 2.0. They are no longer considered model-level evaluable in the implementation, and their implementation has been moved from
org.omg.sysml.expressions.functionstoorg.omg.sysml.execution.expressions.functions.NumericalFunctions::prodNumericalFunctions::sumSequenceFunctions::excludesSequenceFunctions::includesSequenceFunctions::isEmptySequenceFunctions::notEmptySequenceFunctions::sizeStringFunctions::LengthStringFunctions::SubstringNew library function implementations
The following functions have now been implemented as model-level evaluable, per the specification. Unfortunately, a problem with the current specification of the model-level evaluablity of body expressions (see KERML11-178) prevents them from be used in useful cases in model-level expressions. However, they can now be used in non-model-level evaluable expressions.
ControlFunctions::collectControlFunctions::select