Conversation
Tests fail because protected names are being allow when resolving names
to the left of a dot (".").
In initial scope, protected members are resolved only if isInsideScope.
jasonmccsmith
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug in the resolution of names that appear to the right of the dot (
.) in feature chain and related notations.Background
Consider the following:
As shown above, both protected and private members are not visible outside of their namespace (except that protected members are inherited by specialize types). Previously, protected members (but not private members) were visible in feature chains. This was also the case for feature chaining expressions and the left-hand side target of an assignment action.
Code changes
This PR makes a small update to
KerMLScopethat fixes the above anomaly. Visibility rules are now implemented the same for feature chains (and feature chaining expressions and assignment targets) as for segments of a qualified names.