Conversation
seidewitz
changed the title
seidewitz
added a commit
that referenced
this pull request
Oct 20, 2025
ST6RI-888 Owned cross feature implied type not being set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a bug introduced in the resolution of ST6RI-881 in PR #701.
That PR included a refactoring of the caching of the computed
typesof a feature. Before that PR, the cache field was only set after the complete computation of thetypes. The PR changed this so that the cache field was initially set to an empty list, and then that list was filled in during thetypecomputation.Unfortunately, in some cases (such as when a feature has owned metadata), the
typescomputation is called circularly, which previously worked correctly. With the change to the caching, however, the circular call togetTypeinstead returned the empty list that had not yet been filled in. In some cases, this cause the implicit typing of the owned cross feature of an end feature to be set to the empty list (rather than the correct type of the end feature), resulting in the reported bug.The present PR restores the original caching functionality, in which the
typecache field is only set after thetypesare fully computed, which fixes the bug.