Conversation
martynaslelevicius
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the computations of the parameters and end features of a type, which are used in determining the implied redefinitions of those features. The PR also proactively fixes a couple issues with library models that were discovered once the code fix was made:
Code
Behavior_parameter_SettingDelegateStep_parameter_SettingDelegateType_directedFeature_SettingDelegateand inheritdirectedFeaturecomputation.TypeUtilgetAllEndFeaturesOf(type)to calltype.getEndFeature().getAllOwnedEndFeaturesOf(type)to calltype.getOwnedEndFeature().getAllParametersOf(Type)to calltype.getDirectedFeature(). Also removed theskipparameter.Note. Testing with the
SysMLInteractiveProfilerindicate that these changes actually slightly improve performance.FeatureAdaptergetRelevantFeatures(type)so that, if thetargetis an end feature, then, if thetypeis the owner of thetarget, it returnstype.getOwnedEndFeature(), otherwise it returnstype.getEndFeature(). Also removed theskipparameter.ActionUsageAdapterExpressionAdapterMultiplicityAdapterRequirementUsageAdapterskipparameter ofgetRelevantFeatures.SysMLValidatorcheckFlowDefinition, changed the callTypeUtil.getAllEndFeaturesOf(cdef)tocdef.endFeature.Model Libraries
Kernel Semantic Library
TransitionPerformancesTransitionPerformance::accept, removed the nested redefinition ofreciever.TransitionPerformance, added a binding connector betweenaccept.receiverandtriggerTarget.Systems Library
ActionsAction::assignments, added a nested owned parametertarget, which then implicitly redefinesAssignmentAction::targetandassignmentActions::target. As a result,targetis the first parameter ofassignments, followed by the inherited parameterreplacementValues.