Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that caused spurious validation error markings on conditional successions in the Xtext SysML editor in Eclipse.
For example, in the following model, the source of the conditional succession
sis implicitly the preceding actiona:Previously, this would initially parse correctly in the Xtext editor without validation errors. But, if it was part of a larger model, then, when a change was made elsewhere in the model, after incremental re-parsing, the source on the conditional succession was not set correctly, resulting in the validation error “Must have at least two related elements”.
A so-called "conditional succession" is actually parsed as a
TransitionUsage, and an implied source such as above is computed in theTransitionUsage::computeSourcemethod. This PR updates thecomputeSourcemethod to handle the case when transformations are re-run on a conditional succession in the abstract syntax tree, when it has not actually been re-parsed.