ST6RI-857/858/860/861 Semantic transformation bugs#668
Merged
Conversation
- ConnectorUsageAdapter - ViewUsageAdapter - RenderingUsageAdapter
- This is where checkTransitionUsagePayload Specialization is satisfied.
martynaslelevicius
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects several bugs in the implementation of transformation code satisfying semantic constraints from the KerML and SysML specifications
ST6RI-857 Cross feature implicit subsetting is incorrect
This bug resulted in owned cross features subsetting
Base::thingswhen the implied typing by their owning end feature's type meant they should subsetBase::dataValues,Occurrence::occurrencesorObject::objects. It was fixed by moving the call toaddOwnedCrossFeatureSpecializationinFeatureAdapter.addDefaultGeneralTypeto before the callsuper.addDefaultGeneralType. In this way, the implied owned typing for a cross feature is now added before the determination of the default subsetting, which is based on owned typing.ST6RI-858 Incorrect implicit specialization of feature chain invocation result
This bug resulted in the
resultparameter of an invocation expression not properly redefining theresultparameter of itsinstantiatedTypeif that type was a feature chain and the feature target of the chain did not have an ownedresultparameter. It was fixed by replacing the call togetSupertypesOfwithgetGeneralTypesOfinFeatureUtil.getResultParameterOf.ST6RI-860 ConnectionUsages, ViewUsages and RenderingUsages should subset subparts
This bug was that composite
ConnectionUsages,ViewUsagesandRenderingUsagesthat were features ofItemDefinitionsorItemUsageswere not implicitly subsettingItem::subparts. It was fixed by updating the relevant adapter classes to overrideaddDefaultGeneralTypesto handle being a subpart.ST6RI-861 TransitionUsage payload parameter subsetting is incorrect
This bug was that the
payloadparameter of aTransitionUsagewas implicitly subsetting directly thepayloadparameter of thetriggerActionof theTransitionUsage, rather than subsetting a feature chain of thetriggerActionand itspayloadparameter. This was corrected in theReferenceUsageAdapter.addDefaultGeneralTypemethod.