Conversation
martynaslelevicius
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects a non-conformance of the Pilot Implementation with the KerML Specification on the computation of the
Feature::isCompatibleWithoperation.The
isCompatibleWithoperation allows a feature to be considered "compatible with" another feature, even if the first feature is not a specialization of the second. This is necessary to allow the implied featuring types of variable features to be considered compatible in certain cases. But, according to the specification, two features can only be compatible in this way if they both have no nested features. Previously, the Pilot Implementation allowed compatibility if at least one of the features had no nested features, but didn't require both to have no features. This PR changes the implementation to conform to the specification.The non-conformance in the implementation was not actually accidental, however. As previously implemented, the following model was considered valid:
With the change made in this PR, the implied featuring type of the variable feature
xis no longer considered compatible withsnapshots, becausesnapshotshas the nested features, so the subsetting violates thevalidateSubsettingFeaturingTypesconstraint. The workaround is to use the feature chainsnapshots.s, rather than the qualified namesnapshots::s.The intent had been to propose revising the specification of
isCompatibleWithto be similar to the implementation ofisCompatibleWiththat allowed models such as the example above. This did not happen, though, and, since there is generally an easy workaround for the missing capability, it is better for the Pilot Implementation to be conformant to the specification as adopted.