Skip to content

Comments

ST6RI-837: Do not render <<variation>> for EnumerationDefinition#646

Merged
seidewitz merged 1 commit intomasterfrom
ST6RI-837
May 4, 2025
Merged

ST6RI-837: Do not render <<variation>> for EnumerationDefinition#646
seidewitz merged 1 commit intomasterfrom
ST6RI-837

Conversation

@himi
Copy link
Member

@himi himi commented May 3, 2025 •
edited by seidewitz
Loading

By the side effect of the fix by #560, <<variation>> is rendered for EnumerationDefinition because its isVariation is true. However it should not be rendered. This PR fixes this issue.

@himi
Copy link
Member Author

himi commented May 3, 2025

The fix is quite simple and you can easily check it by rendering enum def. For example,

package ST6RI837S {
	enum def E1 {
		enum e1;
		enum e2;
	}	
	enum def E2;
}

is rendered as:

Screenshot 2025-05-03 at 4 56 29 PM

@himi himi requested a review from seidewitz May 3, 2025 20:56
@seidewitz seidewitz merged commit 8d7efe3 into master May 4, 2025
@seidewitz seidewitz self-assigned this May 6, 2025
@seidewitz seidewitz added this to the 2025-04 milestone May 6, 2025
@seidewitz seidewitz added the bug Something isn't working label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seidewitz seidewitz seidewitz approved these changes

Assignees

@seidewitz seidewitz

Labels

bug Something isn't working

Projects

None yet

Milestone

2025-04

Development

Successfully merging this pull request may close these issues.

2 participants

@himi @seidewitz