Conversation
- Also reduced parser splitter count to 18. - Updated ControlNodeTest for control nodes with parameters.
Member
|
I confirmed it worked. However, the graphical notation will be an open issue. The visualization result of the example in action view is as below: Since the standard notation of join node is just a thick line and we have not discussed any notations to specify parameters with it, the flow targets are not rendered. |
himi
approved these changes
May 2, 2025
Member
Author
Yes, updating the graphical notation was specifically left open in the resolution to SYSML2_-262, because we didn't have time to address it. However, for now, just showing the flows as directly incoming/outgoing from the control node symbol is reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR implements the resolution to the following issue, as approved in SysML v2 FTF 2 Ballot 7:
(This should have been implemented in release 2025-02, but it was missed.)
In the SysML abstract syntax,
ControlNodes(i.e.,fork,join,decideandmergenodes) are kinds ofActionUsagesthat are typed byControlActionsfrom the Systems Model Library. The abstract syntax allows control nodes to have any sort of owned members that other kinds of action usages can. However, the textual notation syntax previously allowed only annotations to be declared in the body of a control node. The resolution to SYSML2_-262 corrects this by revising the SysML textual notation grammar to allow control nodes to have regular action bodies.In particular, with this change, it is possible to declare control nodes with parameters, enabling the modeling of flows through them. For example:
Note that it is still necessary to have successions (or succession flows) into and out of control nodes in order to get the proper "control" semantics.