Conversation
…es_and_units.xslx
…ntities_and_units.xslx
…y parse in latest Pilot Implementation
Member
Author
|
@seidewitz
I found one appearance of |
Member
|
For SysML, Everything else looks good. |
…Frame since it is no longer supported
Member
Author
Just committed the removal in this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an amendment on PR#621 that provides a new
quantities_lib_generatortool undertool-support.This tool is able to reproduce the SysML release 2024-12 ISQ library packages with a few differences that are all due to minor naming mistakes in the published release 2024-12 libraries and also three editorial issues.
In particular the naming of coordinate frames in release 2024-12 was inconsistent:
Cartesian3dXxxVectorinstead ofCartesianXxx3dVector, The latter is the correct naming convention that naturally fits with the quantity taxonomy. More specialized concepts prepend qualifiers to the name, e.g., a specialization chain fromVectorQuantityValueto'3dVectorQuantityValue'toPosition3dVectortoCartesianPosition3dVectororCylindricalPosition3dVector.VectorQuantityValuewas used in many places instead of the correct'3dVectorQuantityValue'. Same forVectorMeasurementReferenceinstead of'3dCoordinateFrame'.Also, the following editorial issues were found and fixed:
ISQCondensedMatter.sysmlItem 12-19 Hall coefficient: replaced erroneous unit m^3/Cm^3s^-1A^-1 with correct m^3/C, m^3s^-1*A^-1 (in the Excel workbookdata/iso-iec-80000/iso_iec_80000_quantities_and_units.xlsx). As a consequence, the declaration ofattribute def HallCoefficientUnitwas changed.private import ScalarValues::String;. It was not generated, which is in line with all other ISQ libraries.doccontent of the libraries.A detailed review of all differences between the ISQ library packages in folder
libs_baseline_release-2024-12and the auto-generated library packages in folderlibs_generatedhas been performed. No other differences than those documented above have been found.There are currently no changes to the generation of
SIandUSCustomaryUnits.