Conversation
- No longer creates empty parameters for missing arguments if not necessary. - Updated validation for send action parameters. - Updated ActionTest for newly allowed send node syntax.
- No longer creates an empty parameter if there is no "via" part. - Also updated validation for accept action usage parameters. - Updated PartTest to demonstrate revised syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the resolution to the following issue from SysML v2 FTF2 Ballot 5:
(This resolution should have been implemented in the 2024-12 release, but it was missed.)
The update in this PR improves the expressiveness of send action usage syntax, while still maintaining the parsability of send action usages used as entry, do or exit actions, or used as transition effect actions. In particular, send action usage notation of the following form is allowed, in which all parameters are bound in the send action usage body:
send{inpayload =payloadExpression;insender =senderExpression;inreceiver =receiverExperssion;}as well as the following mixed forms
sendpayloadExpression{insender =senderExpression;inreceiver =receiverExperssion;}and
sendpayloadExpressionviasenderExpression{inreceiver =receiverExperssion;}Further, instead of using feature values, values can also be provided for the nested parameters by using either flows or binding connections outside the send action usage. In addition, in the form
actionactionNamesend viapayloadExpressiontoreceiverExpression;the
payloadparameter is also implicitly redefined, but it can still be referred to by name (e.g.,actionName.payload), for use as the target of a flow or binding connection.There is also a similar update to the syntax for accept action usages. The current syntax is
accepttriggerDeclarationviareceiverExpression;It is now also possible to redefine the receiver parameter (but not the
triggerDeclaration, which declares an output parameter) in the body of the accept action usage, so it can be given a value using an explicit binding or flow. The proposed notation has the form:accepttriggerDeclaration{inreceiver =receiverExpression;}