Conversation
- Also made FeatureImpl::isFeaturedWithin consistent with issue resolution, except for case of "package level" features.
- Added an Xpect parsing test for Comments, including "locale". - Updated KerML.kerml to put quotes around the Comment::'locale' feature name (and updated reserved words in MOF2KerMLText for regenerating the KerML package in the future). - Updated KerMLOutlineTreeProvider to show the "locale" of a Comment (if it is not null). - Updated the JetBrains and VSCode keyword files for KerML.
himi
approved these changes
Feb 25, 2024
Member
himi
left a comment
There was a problem hiding this comment.
I tested it with
package ST6RI738 {
package KERML82 {
classifier A {
feature x;
feature y {
feature z;
}
package B {
feature v;
}
classifier C {
feature w;
}
connector c1 from x to y::z;
connector c2 from x to y.z;
connector c3 from x to B::v;
connector c4 from x to C::w;
}
}
package KERML98 {
doc locale "ja_JP" /* 日本語 */
doc locale "en_US" /* US English */
comment locale "ja_JP" /* コメント */
}
package KERML165 {
feature exp1 = 2 ^ 2 ^ 3;
feature exp2 = (2 ^ 2) ^ 3;
feature exp3 = 2 ^ (2 ^ 3);
}
package KERML307 {
metaclass MC1;
metaclass MC2;
#MC1 #MC2 feature f1;
feature f2 {
#MC1 @MC2;
}
}
}
Member
Member
|
I'll review ST6RI-740, for SysML, hopefully tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR implements resolutions of issues from KerML FTF Ballot 5 that called for updates to the KerML abstract and concrete syntax.
Resolutions of the following issues are implemented in this PR:
Resolution of the following issue only affected the generated UML metamodel files included in PR #534: