Skip to content

ST6RI-723 Resolution SYSML2-467 from SysML v2 FTF Ballot #8#511

Merged
seidewitz merged 3 commits intomasterfrom
ST6RI-723
Nov 22, 2023
Merged

ST6RI-723 Resolution SYSML2-467 from SysML v2 FTF Ballot #8#511
seidewitz merged 3 commits intomasterfrom
ST6RI-723

Conversation

@seidewitz
Copy link
Member

@seidewitz seidewitz commented Nov 21, 2023

This PR implements the resolution to the following issue, as approve in SysML v2 FTF ballot #8:

SYSML2-467 RequirementConstraintUsage should not have a RequirementBody

Specifically:

  1. Previously, the textual notation production RequirementConstraintUsage allowed a require or assume declaration to have a RequirementBody, even though the production produced a ConstraintUsage, for which requirement-specific nested declarations are not actually allowed. This has now been changed to a CalculationBody, which is what is used in other productions for ConstraintUsages.
  2. The ConstraintUsageAdapter no longer physically inserts subject features into requirements constraints (which was not consistent with the specification).
  3. SysMLValidator::checkSubjectMembership no longer makes an exception to validateSubjectMembershipOwningType for requirement constraints.

This means that it is now syntax error to have subject, require and assume declarations in the bodies of requirement constraints in all cases. (In some cases, require and assume declarations were syntactically allowed previously, but still violated the validateRequirementConstraintMembershipOwningType constraint.)

@seidewitz seidewitz self-assigned this Nov 21, 2023
@seidewitz seidewitz requested a review from himi November 21, 2023 18:32
Copy link
Member

@himi himi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it was successfully built and could parse requirements with ReferenceSubsettings, and also confirmed CalculationBody could be specified in require and assume blocks.

@seidewitz seidewitz merged commit a6f5c7c into master Nov 22, 2023
@seidewitz seidewitz added this to the 2023-11 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants