Conversation
Member
seidewitz
commented
Dec 7, 2018
seidewitz
commented
- Updated to 2018-11 baseline metamodel (exported to SysML.uml).
- Switched from standard Ecore code gen to UML2-based code gen, in order to better handle subsetting and redefinition, as used in the SysML MOF metamodel.
- Added handwritten Java code to compute derived meta-attributes. (Also created a Complete OCL file with derivations, but this was not used in the end.)
- Updated .uml metamodel and code as necessary to handle problems with subsetting of composite properties, due to EMF limitations on containment.
- Added Java code to handle initialization of certain required properties based on containment structure that are not set during parsing (such as the "specific" property of a Generalization). (This is probably better handled as a separate post-parsing processing step in the future.)
- Updated tests to reflect updated metamodel and use of derived attributes.
- But does not handle redefinitions.
- The UML2 generator properly handles the subsets and redefinitions used in a CMOF metamodel. - However, the Ecore file still needs to be exported from MagicDraw as before (not as created for UML2), in order to be usable with the Xtext grammar.
- Updated derivations as necessary.
balazsgrill
approved these changes
Dec 11, 2018
balazsgrill
left a comment
balazsgrill
left a comment
There was a problem hiding this comment.
I've looked into the changes, especially of the scope provider implementation and I think they're correct.
seidewitz
added a commit
that referenced
this pull request
Feb 25, 2024
ST6RI-738 Syntax-related issues from KerML FTF Ballot #5
seidewitz
added a commit
that referenced
this pull request
Feb 27, 2024
ST6RI-739 Model-library-related issues from KerML FTF Ballot #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.