feat(core): add support for ParameterBag in Repository.findById #82

Bart van der Hoek · Bart van der Hoek · commit 9b2e79e5bc9b · 2019-07-23T11:57:08.000+02:00
diff --git a/packages/core/__tests__/Resource/Repository.read.test.js b/packages/core/__tests__/Resource/Repository.read.test.js
@@ -109,4 +109,18 @@ describe('The resource repository', () => {
       expect(data).toBe(axiosResponseData.data.data[0]);
     });
   });
+
+  it('should allow a parameter bag in the connector for the findById method to do requests', () => {
+    const connectorFindOne = {
+      fetchOne: jest.fn(() => Promise.resolve(axiosResponseData)),
+    };
+    const repository = repositoryManager.createRepository(connectorFindOne, 'testtype12', identifier);
+    const parameterBag = ParameterBag();
+    parameterBag.setParams('include', 'relation1,relation2');
+
+    repository.findById(12, parameterBag);
+    expect(connectorFindOne.fetchOne.mock.calls).toHaveLength(1);
+    expect(connectorFindOne.fetchOne.mock.calls[0]).toHaveLength(3);
+    expect(connectorFindOne.fetchOne.mock.calls[0][2]).toEqual(parameterBag);
+  });
 });
diff --git a/packages/core/src/Resource/Repository.js b/packages/core/src/Resource/Repository.js
@@ -37,11 +37,11 @@ export default function Repository(connector, resourceType, identifier) {
     },
     /**
      * @param {String|Number} id
-     *
+     * @param {ParameterBag} parameterBag
      * @returns {Promise<Resource>}
      */
-    findById(id) {
-      return connector.fetchOne(this, id, {}).then(
+    findById(id, parameterBag) {
+      return connector.fetchOne(this, id, (typeof parameterBag === 'undefined') ? {} : parameterBag).then(
         response => (response && response.data && response.data.data ? response.data.data : null),
       );
     },
