Add unified memory support for NVIDIA DGX Spark #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use /proc/meminfo MemAvailable instead of sysinfo freeram to properly account for reclaimable cache. Now matches free -h output accurately.
Contributor
Author
|
Update: uses |
Query running processes to sum actual GPU memory usage instead of reporting system-wide memory consumption (MemTotal - MemAvailable).
Owner
|
Nice, I saw the announcement of these systems. Thank you for adding the support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect and handle NVIDIA GPUs with unified memory architecture (e.g., GB10) that use system RAM. When
nvmlDeviceGetMemoryInfofails or returns zero memory, fall back to querying system memory viasysinfo()to report total, used, and free memory statistics.This approach mirrors the existing unified memory handling for Apple M1/M2 GPUs and enables proper memory monitoring for NVIDIA GPUs with unified memory.