Fix runtime directory for Termux on Android by AbhiTheModder · Pull Request #420 · SurgeDM/Surge

AbhiTheModder · 2026-04-28T19:53:23Z

The xdg library returns /run/user/ which doesn't exist on Android.

Added android alongside linux in the GOOS checks so runtime directory falls back to ~/.local/state/surge/runtime instead of failing with 'mkdir /run: read-only file system'.

Greptile Summary

Extends two runtime.GOOS checks in GetRuntimeDir and EnsureDirs to include "android", so that Termux builds fall back to ~/.local/state/surge/runtime instead of trying (and failing) to use /run/user/<uid> from xdg.RuntimeDir. The fix is minimal and correctly scoped — the XDG path is still honoured on Android when XDG_RUNTIME_DIR is explicitly set by the user.

Confidence Score: 4/5

Safe to merge; the change is a two-line, low-risk platform guard with no behavioural impact on non-Android targets.

Only P2 findings (missing tests for the new Android branch). Logic is correct, change is minimal, and existing Linux/Windows/macOS behaviour is unaffected.

No files require special attention beyond the missing test coverage for the Android case in internal/config/paths.go.

Important Files Changed

Filename	Overview
internal/config/paths.go	Adds `runtime.GOOS == "android"` alongside `"linux"` in two conditions to force the state-dir fallback for the runtime directory on Termux, fixing the read-only `/run` filesystem error; logic is correct and minimal.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: internal/config/paths.go
Line: 82-84

Comment:
**No tests for Android path resolution**

The new `runtime.GOOS == "android"` branch in both `GetRuntimeDir` and `EnsureDirs` is untested. A table-driven test overriding the env vars and mocking `runtime.GOOS` (via build tags or a helper variable) would confirm that the fallback to `GetStateDir()/runtime` is taken on Android when `XDG_RUNTIME_DIR` is unset, and that the XDG path is still respected when it is set.

**Rule Used:** What: All code changes must include tests for edge... ([source](https://app.greptile.com/review/custom-context?memory=2b22782d-3452-4d55-b059-e631b2540ce8))

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: support Termux(Android)" | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.

The xdg library returns /run/user/<uid> which doesn't exist on Android. Added android alongside linux in the GOOS checks so runtime directory falls back to ~/.local/state/surge/runtime instead of failing with 'mkdir /run: read-only file system'.

greptile-apps · 2026-04-28T19:54:47Z

+	if (runtime.GOOS == "linux" || runtime.GOOS == "android") && runtimeEnv == "" {
 		runtimeBase = ""
 	}


No tests for Android path resolution

The new runtime.GOOS == "android" branch in both GetRuntimeDir and EnsureDirs is untested. A table-driven test overriding the env vars and mocking runtime.GOOS (via build tags or a helper variable) would confirm that the fallback to GetStateDir()/runtime is taken on Android when XDG_RUNTIME_DIR is unset, and that the XDG path is still respected when it is set.

Rule Used: What: All code changes must include tests for edge... (source)

Prompt To Fix With AI

This is a comment left during a code review. Path: internal/config/paths.go Line: 82-84 Comment: **No tests for Android path resolution** The new `runtime.GOOS == "android"` branch in both `GetRuntimeDir` and `EnsureDirs` is untested. A table-driven test overriding the env vars and mocking `runtime.GOOS` (via build tags or a helper variable) would confirm that the fallback to `GetStateDir()/runtime` is taken on Android when `XDG_RUNTIME_DIR` is unset, and that the XDG path is still respected when it is set. **Rule Used:** What: All code changes must include tests for edge... ([source](https://app.greptile.com/review/custom-context?memory=2b22782d-3452-4d55-b059-e631b2540ce8)) How can I resolve this? If you propose a fix, please make it concise.

SuperCoolPencil · 2026-04-30T17:42:25Z

Hi @AbhiTheModder

Wanted to ask a couple a questions.

Surge doesnt officially support Android yet. I am assuming you build manually and use via cli alone?
Would you want Surge to support Android? If so, why? (I really dont know about the Android DM scene)

AbhiTheModder · 2026-04-30T17:56:53Z

Surge doesnt officially support Android yet. I am assuming you build manually and use via cli alone?

Yep

Would you want Surge to support Android? If so, why? (I really dont know about the Android DM scene)

Obviously, I plan to propose a PR to termux-packages once this gets merged after which the package will be available through termux package manager pkg. As for your other question, I use cli DM a lot, I have used aria2c, axel and many others, just happened to across serge and wanted to give it a try after looking at its benchmarks but that /run issue happened and I explored & applied simplest fix i could think of, loving it so far though I would love if there could be a very similar kind of support like aria2c/axel where I just download through cli flags, (not really fan of opening TUI, or keeping server running when I just need to download 1/2 urls)

SuperCoolPencil · 2026-04-30T18:11:53Z

Amazing! Thanks for contributing :)

Also whenever the PR to termux package manager is merged please let us know so we can add termux to the list of install options.

Happy Downloading 🚀

LukeGTH · 2026-04-30T23:35:18Z

Yo @AbhiTheModder, I've already packaged Surge in Termux, specifically in the Termux User Repository. Since the code is quite stable, I can request that the package be moved to the main repository. The error you resolved had already been fixed with a .patch by Robert Kirkman. I asked him if I could remove the .patch since you adjusted the code.
And yea, you can install the Surge package with: pkg install tur-repo, and pkg install surge-cli.

AbhiTheModder · 2026-05-01T00:28:00Z

@LukeGTH That's great, I do use tur, I forgot to check it up there beforehand lOl, my bad. Awesome.

I can request that the package be moved to the main repository.

That would be nice too, even if not tur is good enough :)

LukeGTH · 2026-05-01T00:58:17Z

By the way, Surge is crashing the terminal (I don't know if it was because of your change or a change you didn't make to the code). If it was, no problem, you were just trying to help, I appreciate your effort.
I should have spoken to Kirkman already, but he hasn't responded yet, and the other devs don't like direct pings.
So, do you want to join the Termux server? @AbhiTheModder I added another @ because I don't know if you're still subscribed to this PR.

LukeGTH · 2026-05-01T01:07:34Z

My mistake, it's not a crash, the terminal just freezes, like starting a daemon without using &

AbhiTheModder · 2026-05-01T01:42:27Z

So, do you want to join the Termux server?

Sure, I would love to

AbhiTheModder · 2026-05-01T01:45:25Z

My mistake, it's not a crash, the terminal just freezes, like starting a daemon without using &

I'm still on my old commit fix on termux and not facing anything like that, so, unrelated to my changes.

Edit: It looks like this commit 73bca40 is related somehow

LukeGTH · 2026-05-01T01:53:19Z

So, do you want to join the Termux server?

Sure, I would love to

Here is the Discord server

LukeGTH · 2026-05-01T01:54:58Z

My mistake, it's not a crash, the terminal just freezes, like starting a daemon without using &

I'm still on my old commit fix on termux and not facing anything like that, so, unrelated to my changes.

Edit: It looks like this commit 73bca40 is related somehow

I figured it wasn't you, how could a detection tool to check if it's Android do that?

LukeGTH · 2026-05-01T01:55:51Z

My name in discord is Luke

SuperCoolPencil · 2026-05-01T04:08:23Z

maybe we need to have some android-specific tests to prevent regressions like this in the future?

would really appreciate if a new issue is created for this!

LukeGTH · 2026-05-01T04:10:32Z

maybe we need to have some android-specific tests to prevent regressions like this in the future?

would really appreciate if a new issue is created for this!

It's up to you, I think it's a good idea

LukeGTH · 2026-05-01T04:13:16Z

maybe we need to have some android-specific tests to prevent regressions like this in the future?

would really appreciate if a new issue is created for this!

It's up to you, I think it's a good idea

I'll open an issue, I'll call Abhi.

LukeGTH · 2026-05-01T04:16:27Z

Wait, I'll do a test; if it works, I won't open an issue.

SuperCoolPencil · 2026-05-01T04:16:50Z

sure @LukeGTH

Thanks :)

LukeGTH · 2026-05-01T04:25:12Z

sure @LukeGTH

Thanks :)

Hmmm, let's open an issue

fix: support Termux(Android)

5180e8c

The xdg library returns /run/user/<uid> which doesn't exist on Android. Added android alongside linux in the GOOS checks so runtime directory falls back to ~/.local/state/surge/runtime instead of failing with 'mkdir /run: read-only file system'.

greptile-apps Bot reviewed Apr 28, 2026

View reviewed changes

SuperCoolPencil approved these changes Apr 30, 2026

View reviewed changes

SuperCoolPencil merged commit 6205957 into SurgeDM:main Apr 30, 2026
8 checks passed

AbhiTheModder deleted the fix/android-termux branch May 1, 2026 00:26

Uh oh!

Conversation

AbhiTheModder commented Apr 28, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Uh oh!

greptile-apps Bot Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

SuperCoolPencil commented Apr 30, 2026

Uh oh!

AbhiTheModder commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SuperCoolPencil commented Apr 30, 2026

Uh oh!

Uh oh!

LukeGTH commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhiTheModder commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

AbhiTheModder commented May 1, 2026

Uh oh!

AbhiTheModder commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

SuperCoolPencil commented May 1, 2026

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

SuperCoolPencil commented May 1, 2026

Uh oh!

LukeGTH commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AbhiTheModder commented Apr 28, 2026 •

edited by greptile-apps Bot

Loading

AbhiTheModder commented Apr 30, 2026 •

edited

Loading

LukeGTH commented Apr 30, 2026 •

edited

Loading

AbhiTheModder commented May 1, 2026 •

edited

Loading

AbhiTheModder commented May 1, 2026 •

edited

Loading