ci: automate extension versioning and upload to AMO#369
Merged
SuperCoolPencil merged 2 commits intomainfrom Apr 14, 2026
Merged
ci: automate extension versioning and upload to AMO#369SuperCoolPencil merged 2 commits intomainfrom
SuperCoolPencil merged 2 commits intomainfrom
Conversation
…ded version from wxt config
…act pathing in CI workflow
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR automates extension versioning by extracting the version from an
ext-v*git tag and runningnpm versionbefore the build, and removes the hardcodedversion: '2.0.0'fromwxt.config.tsso the manifest version is driven bypackage.json.npm versionwill fail on the first release:package.jsonis currently at2.0.0, so pushingext-v2.0.0will hit npm's same-version guard. Adding--allow-same-versionto the command fixes this.releasejob only creates a GitHub release — noweb-ext signor equivalent AMO submission step was added.Confidence Score: 3/5
npm versionsame-version failure would immediately break theext-v2.0.0release build, and the AMO upload (the other half of the stated PR goal) is entirely missing.Important Files Changed
npm versionwill fail on same-version tags and the advertised AMO upload step is missing entirely.version: '2.0.0'from the WXT manifest config so the version is sourced frompackage.json; correct and safe change.Sequence Diagram
sequenceDiagram participant Dev as Developer participant GH as GitHub participant CI as CI Runner (x3: chrome/firefox/edge) participant GHR as GitHub Release participant AMO as Firefox AMO Dev->>GH: "Push tag ext-v*" GH->>CI: Trigger Extension CI/CD CI->>CI: npm ci CI->>CI: Strip ext-v prefix → VERSION CI->>CI: npm version $VERSION --no-git-tag-version CI->>CI: npm run zip (per browser) CI->>GH: "Upload artifact (extension-{browser}.zip)" GH->>GHR: softprops/action-gh-release → Create Release Note over AMO: ❌ Missing: AMO upload stepComments Outside Diff (1)
.github/workflows/extension.yml, line 64-84 (link)The PR title is "ci: automate extension versioning and upload to AMO", but the
releasejob only creates a GitHub release — there is no step to sign or submit the Firefox.zipto addons.mozilla.org. The AMO upload (typically viaweb-ext signor an action liketox0n/amo-upload) using theWEB_EXT_API_KEY/WEB_EXT_API_SECRETsecrets is entirely absent.Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat: automate Firefox extension submiss..." | Re-trigger Greptile