ci: seperate workflows and versions for extension and surge#367
Merged
SuperCoolPencil merged 13 commits intomainfrom Apr 13, 2026
Merged
ci: seperate workflows and versions for extension and surge#367SuperCoolPencil merged 13 commits intomainfrom
SuperCoolPencil merged 13 commits intomainfrom
Conversation
… font-specific utility, and remove stale PR automation.
…y path in CI workflows
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ers to ignore extension path changes
d42e26f to
4b0a1a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR separates the monolithic CI workflow into distinct pipelines for the core Go binary and the browser extension, adds a new reusable
extension-checks.ymlcalled byextension.yml, introduces a dedicatedintegration.yml, renamesbuild.yml/lint.ymltocore-*variants withpaths-ignore: extension/**, removes extension zip artifacts from GoReleaser (handled by the new extension release job), and removes several unrelated workflows and tooling scripts.core-build.yml'spush.branchestrigger is missingpaths-ignore: extension/**— extension-only merges tomainwill needlessly spin up the full 3-OS Go test matrix, inconsistent withcore-lint.ymlwhich correctly excludes extension changes on both triggers.close-stale-prs.yml,flaky-tests.yml,analyze.py, andbenchmark.pyare silently deleted without explanation, bundling unrelated removals into a workflow-separation PR.Confidence Score: 5/5
Safe to merge — all remaining findings are P2 style/efficiency suggestions with no blocking correctness issues
The structural workflow changes are sound: reusable extension-checks, release job properly guarded with if: startsWith(ext-v), build correctly gated on checks, and GoReleaser decoupled from extension artifacts. The two flagged items are a minor paths-ignore inconsistency on push-to-main and bundled unrelated deletions — neither blocks correct CI behaviour.
.github/workflows/core-build.yml — missing paths-ignore on the push.branches trigger
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Push / PR] -->|ext-v* tag| B[extension.yml] A -->|main branch push or PR\nextension/** changes| B A -->|workflow_dispatch| B A -->|main branch push or PR\nnon-extension changes| C[core-build.yml] A -->|v* tag| C B --> D[checks job\ncalls extension-checks.yml] D --> E[lint] D --> F[type-check] D --> G[test] E & F & G --> H[build matrix\nchrome / firefox / edge] H --> I{startsWith\next-v?} I -->|yes| J[release job\nsoftprops/action-gh-release] I -->|no| K[artifacts uploaded only] C --> L[test matrix\nubuntu / macos / windows] L --> M{startsWith\nrefs/tags/v?} M -->|yes| N[GoReleaser release] M -->|no| O[build check only] P[extension/** or .go changes] --> Q[integration.yml\nExtension ↔ Backend tests]Comments Outside Diff (1)
.goreleaser.yaml, line 19 (link)before.hookspath — core release will failscripts/package-release-assets.shwas renamed toscripts/package-fonts.shin this PR, but thebefore.hooksentry here was not updated. GoReleaser will try to execute the old path and fail immediately, so everyv*tag push will produce a broken release run.Prompt To Fix With AI
Prompt To Fix All With AI
Reviews (6): Last reviewed commit: "chore: update workflow concurrency setti..." | Re-trigger Greptile
Context used: