Repository navigation
Commit 222295b
Document frozen embedder API structs (flutter#186842)
## Issue
Part of flutter#38470. The issue asks for embedder API structs that must not be
extended in place to be documented. Review feedback asked what basis was
used to decide which structs were frozen.
## Fix
Narrowed the PR to document only the structs that are already protected
by the `EmbedderFrozen` golden test in
`engine/src/flutter/shell/platform/embedder/tests/embedder_frozen_unittests.cc`.
This removes the earlier unsupported `ABI-sealed` labels from renderer,
backing-store, task, Dart object, and AOT structs that are not covered
by that test-backed source of truth.
## Tests
- `git diff --check`
- Not run: `clang-format --dry-run --Werror
engine/src/flutter/shell/platform/embedder/embedder.h`, because
`clang-format` is not installed in this checkout.
## Risk
Docs-only change to
`engine/src/flutter/shell/platform/embedder/embedder.h`. No generated
output. Other possible sealed embedder structs may still need a separate
verified pass before being documented.
---------
Co-authored-by: gaaclarke <[email protected]>
Co-authored-by: Loïc Sharma <[email protected]>1 parent 8ef2fe4 commit 222295b
1 file changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
392 | 394 | | |
393 | 395 | | |
394 | 396 | | |
| 397 | + | |
395 | 398 | | |
396 | 399 | | |
397 | 400 | | |
| |||
645 | 648 | | |
646 | 649 | | |
647 | 650 | | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
648 | 654 | | |
649 | 655 | | |
650 | 656 | | |
| |||
653 | 659 | | |
654 | 660 | | |
655 | 661 | | |
| 662 | + | |
| 663 | + | |
656 | 664 | | |
657 | 665 | | |
658 | 666 | | |
| |||
668 | 676 | | |
669 | 677 | | |
670 | 678 | | |
| 679 | + | |
| 680 | + | |
671 | 681 | | |
672 | 682 | | |
673 | 683 | | |
| |||
1582 | 1592 | | |
1583 | 1593 | | |
1584 | 1594 | | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
1585 | 1598 | | |
1586 | 1599 | | |
1587 | 1600 | | |
| |||
1789 | 1802 | | |
1790 | 1803 | | |
1791 | 1804 | | |
| 1805 | + | |
| 1806 | + | |
| 1807 | + | |
1792 | 1808 | | |
1793 | 1809 | | |
1794 | 1810 | | |
| |||
0 commit comments