[Dependency] Remove unneeded cryptography dependency#8131
Merged
Conversation
MasterOdin
changed the title
Codecov Report
@@ Coverage Diff @@
## main #8131 +/- ##
=========================================
Coverage 22.21% 22.21%
Complexity 7588 7588
=========================================
Files 203 203
Lines 24796 24796
Branches 60 60
=========================================
Hits 5509 5509
Misses 19229 19229
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. |
williamjallen
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
Right now, we install an old version of the
cryptographypython dependency. While we did not directly utilize this package, some of our other dependencies did, and would install the newest possible version of the dependency. However, the version of pip that came with Ubuntu 18.04 was not new enough to support installing these newer versions, and so we pinned this transitive dependency.What is the new behavior?
Remove the install line for
cryptographyand let it get installed as a transitive dependency again. The version of pip that comes with Ubuntu 20.04 is new enough to support the binary installs for these versions, and so we don't need to worry about this anymore.Other information?
Vagrant up run: https://github.com/Submitty/Submitty/actions/runs/2605815217