[Bugfix:TAGrading] Lab navigation for checkpoint fix#7894
Merged
Conversation
Eceptonsu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7894 +/- ##
============================================
- Coverage 21.94% 21.39% -0.55%
- Complexity 7474 8440 +966
============================================
Files 198 199 +1
Lines 24386 26986 +2600
Branches 54 57 +3
============================================
+ Hits 5352 5775 +423
- Misses 18980 21158 +2178
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
williamjallen
requested changes
May 17, 2022
williamjallen
left a comment
williamjallen
left a comment
Member
There was a problem hiding this comment.
After reaching the bottom, the focus seems to wrap around to the top again when scrolling down. The reverse is not true though, so if you are at the top and try to scroll up, it does not go to the bottom. Should this behavior be standardized in both directions? Personally, I think it shouldn't wrap in either direction, but if someone proposed a good use case for it, I wouldn't have a problem with it.
williamjallen
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Fixes #7761
If the user tries to navigate vertically with the arrow keys through the lab checkpoints, the selection will move 2 cells at once. The arrow keys also do not work in the null section.
What is the new behavior?
The arrow keys now correctly move 1 cell at a time when the user wants to navigate vertically. They also function correctly in null sections.
2022-05-16-23-01-47.mp4