Skip to content

[Feature:InstructorUI] Add registration subsection#6145

Merged
bmcutler merged 8 commits into
masterfrom
add_registration_subsection
Jan 23, 2021
Merged

[Feature:InstructorUI] Add registration subsection#6145
bmcutler merged 8 commits into
masterfrom
add_registration_subsection

Conversation

@vikrsri

@vikrsri vikrsri commented Jan 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements:

  • The PR title and message follows our guidelines
  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

What is the current behavior?

There is currently no way to put students into subsections, allowing further sorting of students.
Addresses #6064.

What is the new behavior?

This PR adds a registration subsection that can be set by an instructor. Further PR's will allow sorting and grading by students' registration subsections.

The subsection can be set when an instructor either edits or adds a new student in the Manage Students page. If a subsection has been set for a student, it will be appended to the student's registration section in the Manage Students page. Otherwise, there will be no change.

bmcutler
bmcutler requested changes Jan 19, 2021
View reviewed changes
Comment thread migration/migrator/migrations/course/20210113174909_registration_subsection.py Outdated
Comment thread migration/migrator/migrations/course/20210113174909_registration_subsection.py Outdated
@codecov

codecov Bot commented Jan 20, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6145 (693154c) into master (e9db4a6) will decrease coverage by 0.00%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6145      +/-   ##
============================================
- Coverage     22.26%   22.26%   -0.01%     
- Complexity     6467     6469       +2     
============================================
  Files           160      160              
  Lines         21148    21153       +5     
============================================
+ Hits           4709     4710       +1     
- Misses        16439    16443       +4
Flag Coverage Δ Complexity Δ
autograder 14.16% <ø> (ø) 0.00 <ø> (ø)
migrator 99.10% <ø> (ø) 0.00 <ø> (ø)
php 20.98% <11.11%> (-0.01%) 0.00 <0.00> (ø)
python_submitty_utils 71.83% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@vikrsri
vikrsri marked this pull request as ready for review January 22, 2021 02:45
@vikrsri vikrsri changed the title [WIP] [Feature:InstructorUI] Add registration subsection [Feature:InstructorUI] Add registration subsection Jan 22, 2021
@vikrsri
vikrsri requested a review from bmcutler January 22, 2021 04:08
bmcutler
bmcutler approved these changes Jan 22, 2021
View reviewed changes

@bmcutler bmcutler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review and quick test look ok! Thanks!
This is what we agreed for the step 1 PR.

@MasterOdin -- @vikrsri and I discussed the unexpected additional edits to the .sql file (changes were made using the postgres dump instructions... ). Can you please review and advise?

@bmcutler
bmcutler requested a review from MasterOdin January 22, 2021 04:59
MasterOdin
MasterOdin approved these changes Jan 22, 2021
View reviewed changes
Comment thread site/app/models/User.php Outdated
Comment thread site/app/models/User.php Outdated
@MasterOdin

MasterOdin commented Jan 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

The SQL file changes are fine. The gradeable_access table was added by hand in #5623 and then no one has run the dump DB command since then. The reason for that it looks like gradeable_access's schema changed is that SERIAL is a pseudo-type in postgresql that translates under the hood to creating a sequence, assigning ownership, etc. It's a shorthand that the pg_dump command does not use, as pg_dump is outputting something that is more inline with how the data structures are actually stored in the DB.

@bmcutler
bmcutler merged commit 30fb383 into master Jan 23, 2021
@bmcutler
bmcutler deleted the add_registration_subsection branch January 23, 2021 23:12
@bmcutler bmcutler mentioned this pull request Feb 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes
@bmcutler bmcutler bmcutler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vikrsri @MasterOdin @bmcutler @emaicus