[UI/UX:InstructorUI] Notebook Builder Add Itempool Support#5842
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5842 +/- ##
============================================
- Coverage 22.40% 22.39% -0.01%
Complexity 6231 6231
============================================
Files 157 157
Lines 20405 20409 +4
============================================
Hits 4571 4571
- Misses 15834 15838 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
mukul-kmr-jha
suggested changes
Aug 25, 2020
shailpatels
approved these changes
Aug 27, 2020
shailpatels
left a comment
shailpatels
left a comment
Member
There was a problem hiding this comment.
Changes look good and works as described
Had no issues adding removing and editing itempools and adding items to notebook configs, interfaces was easy to use as well - looks good to merge
bmcutler
added a commit
that referenced
this pull request
Sep 17, 2020
* [Feature:Submission] Rework gradeable access log Signed-off-by: Matthew Peveler <[email protected]> * fix timelimit custom validator example * Revert "[Feature:InstructorUI] Notebook Builder Add Itempool Support (#5842)" This reverts commit 7db8cac. * temporarily replace websocketclient with mock * sorry matt, i had to disable these php unit tests * update phpunit tests for new file made on submission * Revert "sorry matt, i had to disable these php unit tests" This reverts commit 9c354cc. * fix js linting * Revert "Revert "[Feature:InstructorUI] Notebook Builder Add Itempool Support (#5842)"" This reverts commit 40a093d. * Reverted mock websockets * Added access table to course_tables.sql * wip Co-authored-by: Barb Cutler <[email protected]> Co-authored-by: Barb Cutler <[email protected]> Co-authored-by: Evan Maicus <[email protected]> Co-authored-by: Shail <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Notebook Builder lacks support for itempools.
What is the new behavior?
Itempool support has been added to the Notebook Builder. Some code has been refactored for better reuse.