[Bugfix:RainbowGrades] Revert reload on build success#13049
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13049 +/- ##
=========================================
Coverage 21.12% 21.12%
Complexity 10114 10114
=========================================
Files 279 279
Lines 38125 38125
Branches 578 578
=========================================
Hits 8053 8053
Misses 29507 29507
Partials 565 565
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
marked this pull request as ready for review
July 16, 2026 14:38
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
bmcutler
approved these changes
Jul 16, 2026
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
In PR#13026, I added a reload on build success to clear the manual generation banner if it was present. This had the side effect of changing the message shown by the output of building rainbow grades, which broke the grades configuration spec. The reload would also clear the log button, so this change is better reverted and I can work on a fix for clearing the banner in another PR.
What is the New Behavior?
The page will no longer reload on a successful build of rainbow grades.
What steps should a reviewer take to reproduce or test the bug or new feature?
Other information
N/A