[Bugfix:InstructorUI] Course Staff Table Highlight#13037
Merged
Conversation
fixes alternating row colors for gradeable tables, and reuses existing row counter css to add counters to these tables (the hacky part, because of code reuse). A better solution would be to unify these tables styles in one file, but that would require its own pr because table css is distributed and messy.
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13037 +/- ##
============================================
+ Coverage 21.09% 21.11% +0.01%
Complexity 10115 10115
============================================
Files 279 279
Lines 38167 38133 -34
Branches 585 578 -7
============================================
Hits 8051 8051
+ Misses 29544 29517 -27
+ Partials 572 565 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
NicholasCiuica
marked this pull request as ready for review
July 14, 2026 18:43
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
mattLif
approved these changes
Jul 15, 2026
mattLif
left a comment
mattLif
left a comment
Contributor
There was a problem hiding this comment.
I verified that staff names are highlighted on gradeable details pages on both light and dark mode. Code looks good too.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes #12584, Related to #12996
Should only be merged after #12996 for easier testing and important CSS changes
What is the New Behavior?
Course staff are now properly highlighted on the Simple Grading and Gradeable Details pages. Also, the Gradeable Details page also uses the same blue to highlight the course staff as the rest of the gradeable tables.
What steps should a reviewer take to reproduce or test the bug or new feature?
Please follow the testing procedure on multiple browsers (at least Chromium and Firefox).
i. Open a gradeable with student file submission
ii. Make a Numeric gradeable with at least on numeric column and at least one text column
iii. Make a Checkpoint gradeable with at least one checkpoint column and at least one text column
EDIT: Please ensure that on the numeric and checkpoint gradeables row highlighting stops at the user's identifying information, so that the highlight doesn't interfere with checkpoint grading cells or numeric/text input cells.
e.g.
Automated Testing & Documentation
There are currently no tests that check for highlighted staff rows in the gradeable tables. Should there be?