Skip to content

[Bugfix:RainbowGrades] Revert accidential changes#13028

Merged
bmcutler merged 2 commits into
mainfrom
revert-accidential-changes
Jul 13, 2026
Merged

[Bugfix:RainbowGrades] Revert accidential changes#13028
bmcutler merged 2 commits into
mainfrom
revert-accidential-changes

Conversation

@dagemcn

@dagemcn dagemcn commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Why is this Change Important & Necessary?

In PR#13002, I accidentally pushed changes intended for a different branch. This PR reverts those changes.

What is the New Behavior?

Should be the same as on main, with rainbow grades functioning normally.

This PR also fixes an error you get when trying to view the gradebook introduced by the accidentally included changes:
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Run submitty_install_site
  2. Navigate to any course as instructor
  3. Test features related to rainbow grades (specifically, building and viewing grades)

Automated Testing & Documentation

N/A

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Jul 10, 2026
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jul 10, 2026
@codecov

codecov Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.32%. Comparing base (7fc5530) to head (ce7ccfd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #13028      +/-   ##
============================================
+ Coverage     21.29%   21.32%   +0.02%     
+ Complexity    10098    10085      -13     
============================================
  Files           278      278              
  Lines         37794    37742      -52     
  Branches        516      516              
============================================
  Hits           8050     8050              
+ Misses        29241    29189      -52     
  Partials        503      503
Flag Coverage Δ
autograder 21.16% <ø> (ø)
js 1.98% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.24% <0.00%> (+0.03%) ⬆️
python_submitty_utils 79.83% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)
vue 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dagemcn
dagemcn marked this pull request as ready for review July 10, 2026 19:20
@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Jul 10, 2026
elsume
elsume approved these changes Jul 13, 2026
View reviewed changes

@elsume elsume left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I launched the website while on the main branch and confirmed that trying to access the gradebook would show an error page. I then went over the reverted files and compared them to the initial files in PR#13002. Going over them, I can confirm that all the affected files are now reverted with this PR. I then switched over to this PR's branch. While testing, I was able to successfully generate rainbow grades then view them on the gradebook. Everything, especially rainbow grades, seems to be functioning as it was before PR#13002.

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jul 13, 2026
@bmcutler
bmcutler merged commit a4ecc63 into main Jul 13, 2026
61 of 62 checks passed
@bmcutler
bmcutler deleted the revert-accidential-changes branch July 13, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elsume elsume elsume approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dagemcn @elsume @bmcutler