[Bugfix:TAGrading] Fix Stoplight Yellow#13023
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13023 +/- ##
=========================================
Coverage 21.25% 21.25%
Complexity 10093 10093
=========================================
Files 278 278
Lines 37778 37778
Branches 516 516
=========================================
Hits 8031 8031
Misses 29244 29244
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
approved these changes
Jul 10, 2026
dagemcn
left a comment
dagemcn
left a comment
Member
There was a problem hiding this comment.
Tested, looks good, the grading page looks much better with this change.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
On dark mode, "vibrant yellow" turns to a darker shade, causing the "limited access grader verified" stoplight to change color to not match the "Component graded by a limited access grader" stoplight. This PR fixes this by changing the former's yellow color to match the yellow used in the latter's css.
What is the New Behavior?
Before:
After
What steps should a reviewer take to reproduce or test the bug or new feature?
On dark mode, visit any gradeable's details page and notice the change in the legend
Automated Testing & Documentation
No automated testing
Other information
Not a breaking change
No migrations
Not a security risk