[Feature:TAGrading] Change Peer Grading Purple#13015
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13015 +/- ##
=========================================
Coverage 21.25% 21.25%
Complexity 10093 10093
=========================================
Files 278 278
Lines 37778 37778
Branches 516 516
=========================================
Hits 8031 8031
Misses 29244 29244
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
left a comment
dagemcn
left a comment
There was a problem hiding this comment.
Looks good, I was able to verify that all peer components are now using the updated color using git grep. The only remaining usage has to do with the config editor. The new color appears as expected in the peer components, tested with the border around rubric entries, the peer stoplights, peer progress bar. Approving.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
|
@mattLif |
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
3 participants
Why is this Change Important & Necessary?
The "plum-purple" that is used for Peer Grading elements is difficult to distinguish because of how dark it is. "mediumorchid" is superior due to its vibrance, making it much more noticeable
What is the New Behavior?
Before:
After:
What steps should a reviewer take to reproduce or test the bug or new feature?
As an instructor, visit pages where you would expect to see peer grading purple and verify it is now "mediumorchid"
Automated Testing & Documentation
No automated testing added
Other information
Not a breaking change
No migrations
Not a security concern