[Feature:RainbowGrades] Gradebook choose sorted table#13014
Conversation
This reverts commit 1e8f961.
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13014 +/- ##
============================================
- Coverage 21.16% 21.12% -0.04%
- Complexity 10102 10124 +22
============================================
Files 285 285
Lines 38769 38842 +73
Branches 596 596
============================================
Hits 8205 8205
- Misses 29982 30055 +73
Partials 582 582
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
|
I ran into an issue while reviewing. See the Rainbow Grades Configuration build logs below. It seems the sort table button on the Gradebook page never shows up because the tables are not generated. 
|
There was a problem hiding this comment.
I did a functionality and code review of this PR and overall I would say it looks good. I was able to test that all of the new tables did generate, could be selected from the dropdown menu in the Gradebook. Also, the files themselves were valid and could be viewed manually as some instructors choose to do (the .html and .csv files).
One small thing i was wondering about, would it be to our advantage here to make a new folder for the output* to go into instead? It seems like if we were to add many more different types to be output here that it would get cluttered with a lot of different output files here. However, as it is right now, I don't necessarily think this is a problem so I will be approving.
Edit, I saw Nick's error before doing a vagrant halt & up to link the changes from my Submitty/RainbowGrades folder. I think I needed to do this because I had just newly created / cloned that folder on my machine.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Work in Progress
in Submitty Development
|
@dagemcn |
automateprojectmangement
Bot
moved this from Work in Progress
to In Review
in Submitty Development
roye2
left a comment
roye2
left a comment
There was a problem hiding this comment.
The change to move the code additions out of rainbowgrades and into here looks good. I also tested the functionality and everything seemed to work. I just have a small comment about wording.
roye2
left a comment
roye2
left a comment
There was a problem hiding this comment.
With the updates to the wording, I am approving this PR as I've tested it and it works well, and the code looks good.
4 participants
Why is this Change Important & Necessary?
Closes Issue#10273.
What is the New Behavior?
Before, the instructor gradebook could only be sorted by overall due to how the table was generated and displayed. Now, whenever an instructor builds rainbow grades from the grades configuration page, the gradebook will now have a dropdown to choose which sorted table to view.
The CSV download will now download the CSV of whatever sorting order is selected.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
This feature is not tested by automated testing.