Skip to content

[Feature:TAGrading] Update Modal Text#13013

Merged
bmcutler merged 1 commit into
mainfrom
csv-upload-text-refactor
Jul 8, 2026
Merged

[Feature:TAGrading] Update Modal Text#13013
bmcutler merged 1 commit into
mainfrom
csv-upload-text-refactor

Conversation

@dandrecollins07-ctrl

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Currently the modal for the new Upload CSV does not specify that the Total column is optional. This new behavior allows future instructors/TAs to see that they don't need to have the Total column and that it will be self-calculated.

What is the New Behavior?

One line Twig change, with clarification on allowed column rules.

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. run submitty_install_site
  2. Open a numeric/text gradeable
  3. Go to upload CSV, notice the new text at the bottom of the Modal

Automated Testing & Documentation

N/A

Other information

N/A

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.29%. Comparing base (6582e94) to head (6316238).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #13013   +/-   ##
=========================================
  Coverage     21.29%   21.29%           
  Complexity    10071    10071           
=========================================
  Files           278      278           
  Lines         37697    37697           
  Branches        516      516           
=========================================
  Hits           8028     8028           
  Misses        29166    29166           
  Partials        503      503           
Flag Coverage Δ
autograder 21.16% <ø> (ø)
js 1.98% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.20% <ø> (ø)
python_submitty_utils 79.83% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)
vue 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roye2 roye2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jul 8, 2026
@bmcutler
bmcutler merged commit 233f2c9 into main Jul 8, 2026
30 checks passed
@bmcutler
bmcutler deleted the csv-upload-text-refactor branch July 8, 2026 20:24
parthrajsinghbhati pushed a commit to parthrajsinghbhati/Submitty that referenced this pull request Jul 10, 2026
### Why is this Change Important & Necessary?
Currently the modal for the new Upload CSV does not specify that the
Total column is optional. This new behavior allows future
instructors/TAs to see that they don't need to have the Total column and
that it will be self-calculated.

### What is the New Behavior?
One line Twig change, with clarification on allowed column rules.

### What steps should a reviewer take to reproduce or test the bug or
new feature?

1. run submitty_install_site
2. Open a numeric/text gradeable
3. Go to upload CSV, notice the new text at the bottom of the Modal

### Automated Testing & Documentation
N/A

### Other information
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants