[Bugfix:InstructorUI] Phantom files notebook sub#13009
Merged
Merged
Conversation
This reverts commit 1e8f961.
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
dagemcn
changed the title
dagemcn
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13009 +/- ##
============================================
- Coverage 21.29% 21.29% -0.01%
Complexity 10071 10071
============================================
Files 278 278
Lines 37697 37698 +1
Branches 516 516
============================================
Hits 8028 8028
- Misses 29166 29167 +1
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
changed the title
dagemcn
changed the title
dagemcn
changed the title
dagemcn
changed the title
dagemcn
changed the title
dagemcn
changed the title
dagemcn
changed the title
dagemcn
marked this pull request as ready for review
July 7, 2026 15:42
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
mattLif
approved these changes
Jul 7, 2026
mattLif
left a comment
mattLif
left a comment
Contributor
There was a problem hiding this comment.
Tested again with same process as PR#13002, and the triple file appearance bug is gone now.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
dagemcn
changed the title
parthrajsinghbhati
pushed a commit
to parthrajsinghbhati/Submitty
that referenced
this pull request
Jul 10, 2026
### Why is this Change Important & Necessary? Closes [Issue#13001](Submitty#13001) ### What is the New Behavior? Prior to the changes, the notebook builder submission box would show 3 files when you had previously submitted just one. <img width="2280" height="846" alt="image" src="https://github.com/user-attachments/assets/159e9d4b-16ae-4764-814e-e33ed3940516" /> After the changes, the submission box only shows the one file that was submitted. <img width="1372" height="456" alt="Screenshot 2026-07-07 at 11 24 52 AM" src="https://github.com/user-attachments/assets/ef324f0a-9eaa-40ad-bfd3-c15475e00bb4" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Go to any gradeable with a notebook file submission component (notebook_filesubmission in sample) 2. Submit a file in the submission box 3. Observe error ### Automated Testing & Documentation This feature is not tested by E2E tests. --------- Co-authored-by: Barb Cutler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes Issue#13001
What is the New Behavior?
Prior to the changes, the notebook builder submission box would show 3 files when you had previously submitted just one.
After the changes, the submission box only shows the one file that was submitted.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
This feature is not tested by E2E tests.