[Bugfix:System] use shutil.move#13008
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13008 +/- ##
=========================================
Coverage 21.32% 21.32%
Complexity 10055 10055
=========================================
Files 278 278
Lines 37646 37646
Branches 516 516
=========================================
Hits 8028 8028
Misses 29115 29115
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
Since this PR updates a migration from a prior PR, it is failing the migration timestamp date CI check, but that's as expected. |
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
parthrajsinghbhati
pushed a commit
to parthrajsinghbhati/Submitty
that referenced
this pull request
Jul 10, 2026
### Why is this Change Important & Necessary? PR Submitty#12952 used Python path.rename, which unfortunately does not work when the source and destination files are in different partitions. ### What is the New Behavior? We switch to using Pythons shutil package instead. ### What steps should a reviewer take to reproduce or test the bug or new feature? This change is only significant if the /usr and /var directories are located on different partitions. ### Automated Testing & Documentation Not included in automated testing. We could update our vagrant & CI system setups to have more complicated (& realistic) partition setups. But this is not high priority to do at this time. ### Other information none. Co-authored-by: Barb Cutler <Barb Cutler>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
PR #12952 used Python path.rename, which unfortunately does not work when the source and destination files are in different partitions.
What is the New Behavior?
We switch to using Pythons shutil package instead.
What steps should a reviewer take to reproduce or test the bug or new feature?
This change is only significant if the /usr and /var directories are located on different partitions.
Automated Testing & Documentation
Not included in automated testing.
We could update our vagrant & CI system setups to have more complicated (& realistic) partition setups.
But this is not high priority to do at this time.
Other information
none.