[Feature:InstructorUI] Numeric CSV Suggestions#13007
Conversation
make the popup text for Upload CSV button clearer
Can be confusing because table is not visually updated until reload, which takes place a few seconds after this message.
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
NicholasCiuica
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## numeric-gradeable-csv-upload #13007 +/- ##
===============================================================
Coverage 21.26% 21.26%
Complexity 10079 10079
===============================================================
Files 277 277
Lines 37688 37688
Branches 513 513
===============================================================
Hits 8014 8014
Misses 29172 29172
Partials 502 502
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| <p> | ||
| All other columns are ignored. | ||
| </p> | ||
| <br /> |
There was a problem hiding this comment.
The only change that I'm unsure about is the wording change here for the upload form, because I believe the previous iteration was closer to the wording on other popups already in Submitty. Please let me know what you think of this wording, and if you'd like you can commit to this PR changing the wording as you see fit.
There was a problem hiding this comment.
Yeah, although the current word is a little repetitive. That is how Submitty's format is usually structured so I think I will keep it that way.
There was a problem hiding this comment.
Yeah, although the current word is a little repetitive. That is how Submitty's format is usually structured so I think I will keep it that way.
Oh I also forgot to mention though, I do think the "Total" column should be mentioned somewhere in the description, maybe adding it to the list of optional columns with a note like the one I mentioned.
There was a problem hiding this comment.
Yeah, although the current word is a little repetitive. That is how Submitty's format is usually structured so I think I will keep it that way.
Oh I also forgot to mention though, I do think the "Total" column should be mentioned somewhere in the description, maybe adding it to the list of optional columns with a note like the one I mentioned.
The initial intentions of the Upload PR were to have the total automatically update but this seems to not be working here.
Edit: change $has_total_col = isset($col_index['Total']); to $has_total_col = false;
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
2d8e1d1
into
numeric-gradeable-csv-upload
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
2 participants
Why is this Change Important & Necessary?
Builds off of #12995 and #12998
What is the New Behavior?
This PR includes some recommended changes I have for the newly introduced Numeric Gradeable CSV upload/download features (#12995 and #12998).
What steps should a reviewer take to reproduce or test the bug or new feature?
This PR includes the following: