[Feature:TAGrading] Add Peer Progress Bar#13006
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13006 +/- ##
============================================
- Coverage 21.32% 21.28% -0.04%
- Complexity 10055 10080 +25
============================================
Files 278 278
Lines 37646 37725 +79
Branches 516 516
============================================
+ Hits 8028 8031 +3
- Misses 29115 29191 +76
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
previously the peer bar was green because another styling overwrote this style
NicholasCiuica
left a comment
NicholasCiuica
left a comment
There was a problem hiding this comment.
It looks like the new bar is functioning properly. I got a purple bar on the
Released Peer PDF Homework gradeable as instructed, and I also got one to show up after making my own peer gradeable and doing some student grading. I tested that both peer grades from students and from instructors add to the bar. I also tested that students don't see the bar. One recommendation I have is to possibly pick a brighter purple color for the peer grading bar so it stands out better in dark mode (e.g. --standard-mediumorchid) but this change goes beyond the scope of this PR so it can be investigated later.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
|
as discussed in meeting, we will replace the plum color with orchid color for all peer grading on both light & dark modes. this will be in a separate PR. |
### Why is this Change Important & Necessary? Closes [Submitty#10391](Submitty#10391) ### What is the New Behavior? A second purple progress bar will appear on non-team gradeables with peer grading components. This progress bar represents the % of students within the peer grading matrix who have received at least one peer grading response from another student. Before: <img width="934" height="54" alt="image" src="https://github.com/user-attachments/assets/98c76dba-60db-4132-b081-65c50ad41243" /> After: <img width="956" height="63" alt="image" src="https://github.com/user-attachments/assets/189ac87d-f853-4253-8b57-b2987675c81b" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? A reviewer can either test with a preexisting gradeable (described in steps) or make their own 1. Observe Released Peer PDF Homework on sample as an instructor 2. Should have purple progress bar since only peer components 3. Edit the gradeable and add a normal grading component to the rubric 4. Go in and grade that component for a student in a section assigned to instructor (ex. adamsg) 5. Observe the green progress bar now appears on the gradeable as well ### Automated Testing & Documentation This feature does not currently have automated testing. ### Other information Not a breaking change No migrations Not a security concern --------- Co-authored-by: NicholasCiuica <[email protected]>
3 participants
Why is this Change Important & Necessary?
Closes #10391
What is the New Behavior?
A second purple progress bar will appear on non-team gradeables with peer grading components. This progress bar represents the % of students within the peer grading matrix who have received at least one peer grading response from another student.
Before:
After:
What steps should a reviewer take to reproduce or test the bug or new feature?
A reviewer can either test with a preexisting gradeable (described in steps) or make their own
Automated Testing & Documentation
This feature does not currently have automated testing.
Other information
Not a breaking change
No migrations
Not a security concern