[Feature:InstructorUI] Add file submission to notebook builder#13002
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13002 +/- ##
============================================
- Coverage 21.28% 21.25% -0.03%
- Complexity 10080 10093 +13
============================================
Files 278 278
Lines 37726 37778 +52
Branches 516 516
============================================
Hits 8031 8031
- Misses 29192 29244 +52
Partials 503 503
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dagemcn
changed the title
dagemcn
marked this pull request as ready for review
July 6, 2026 13:11
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
mattLif
approved these changes
Jul 7, 2026
mattLif
left a comment
mattLif
left a comment
Contributor
There was a problem hiding this comment.
I tested by creating a notebook for a gradeable with a file submission cell saving submissions to a folder called "problem_1." After submitting, I verified the submitted files were saved to the specified directory:
Code looks good as well. I also observed the triple file bug that was mentioned in the PR's description. I'm approving.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
bmcutler
reviewed
Jul 8, 2026
bmcutler
left a comment
bmcutler
left a comment
Member
There was a problem hiding this comment.
Are you verifying that each directory is unique? I see that you have it in the instructions, but I don't see it being checked for in the code. (I might have missed it.)
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
parthrajsinghbhati
pushed a commit
to parthrajsinghbhati/Submitty
that referenced
this pull request
Jul 10, 2026
…tty#13002) ### Why is this Change Important & Necessary? Closes [Issue#12676](Submitty#12676) ### What is the New Behavior? After the changes: <img width="2760" height="702" alt="image" src="https://github.com/user-attachments/assets/a7b44c3f-533a-42f1-b45a-4757c0acb1f7" /> Prior there was no file submission button. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Create a new greadeable 2. Fill in the title, URL, and ID 3. Select `Students will submit one or more files by direct upload to the Submitty website` 4. Select no for the other two options that appear 5. Create the new gradeable 6. Scroll down to the notebook builder section and click create new 7. Verify that there is an option present for file submission 8. Insert a file submission module 9. Save the notebook 10. Verify that you can submit to the notebook gradeable and that the file you submitted appears in the directory you specified ### Automated Testing & Documentation This feature is not tested by Cypress. ### Other information This is not a breaking change. There is no migration in this PR. There are no known security concerns with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes Issue#12676
What is the New Behavior?
After the changes:
Prior there was no file submission button.
What steps should a reviewer take to reproduce or test the bug or new feature?
Students will submit one or more files by direct upload to the Submitty websiteAutomated Testing & Documentation
This feature is not tested by Cypress.
Other information
This is not a breaking change.
There is no migration in this PR.
There are no known security concerns with this PR.